On 11/19/2022 9:02 AM, Tomek CEDRO wrote:
On Sat, Nov 19, 2022 at 3:53 PM Thiago Costa de Paiva wrote:
From these, the valid argument is that it would be non-standard (not a top
level name) related to Appache rules, which I think is indeed not acceptable.
It would not imply any source code organization change nor submodules:
git clone <appache url>/nuttx/core nuttx
git clone <appache url>/nuttx/apps apps
The use of submodules was also considered before (I also proposed
that) and turned out to be a bad idea :-) :-)
At one time, I was moving all major NuttX components into sub-modules
in order to better modularize the system. I had arch/ and
Documentation/ moved into their own repositories.
But I got endless complaints from users. Everyone hated this so I ended
up merging these back into nuttx/. That was a tough job because of the
duplicated history in the nuttx/, arch/, and Documentation/
repositories. I really wouldn't recommend going through that again.
Anyway, from all the discussion, since hyphens should not be used according to
what Greg said previously, I think we have only two options:
nuttx
nuttx_apps
Then you are pro option 1 :-)
I was an underscore fan. There are reasons to use underscores and
reasons to use hyphens -- none are very compelling so I suppose this
really ends up being just a personal preference.
But I think NuttX should follow the pattern of other 2.4K Apache
projects. See https://gitbox.apache.org/repos/asf . All naming follows
these rules:
* The repository name begins with the project name (I see a couple of
exceptions in old projects like NetBeans)
* If there is more than one repository, the project name is followed
by a hyphen and a component name
* ONLY hyphens are used. In all cases, hyphens are used to separate
words in the repository name. There is not a single usage of
underscore for this in the all 2.4K repository name.
Example:
mynewt-core.git
I think it is important to be consistent with other Apache project
naming. Therefore, I am now a hyphen advocate.
On Thu, Nov 17, 2022 at 10:47 PM Nathan Hartman
<hartman.nat...@gmail.com> wrote:
(..)
In the discussion from a few months ago [1] several reasons were given
why not to use hyphens in the names (they confuse some tools and
underscores are safer).
Two possibilities for repo names were given:
1) nuttx and nuttx_apps
or
2) nuttx_rtos and nuttx_apps
Based on my experience I am pro 2 choice as it clearly distinguishes
rtos part from the apps part, is a self explanatory at first sight,
and is more compatible with the potential use cases.. also as Gregory
explained this nuttx_rtos part is really the whole RTOS part :-)
If we are like other projects and use hyphens, these would be:
1) nuttx and nuttx-apps, or
2) nuttx-rtos and nuttx-apps
Since NuttX is the name of the RTOS. nuttx-rtos is kind of redundant,
but not terrible.
