Bruno,I like the approach you are taking (an ant target that writes the rev id into a text file that is then included into the footer). However, it would be great if you would address the following scenarios/:
1) svn is not available: the build process should proceed without errors2) the ant svn plugin is not available (I think it is an optional lib): the build process should proceed without errors 3) internate connection is not available when the ant target is invoked: the build process should proceed without errors
4) evaluate possible license issues (if any) with the ant svn plugin 5) (as Tim mentioned) the trunk was exported instead of checked out Ideally, in all these situations the footer should show an empty rev id.Also, where should we place the text file with the rev number in it? I'd suggest in the runtime folder (so that we don't write files inside the framework).
Just my 2 cents, Jacopo On Feb 3, 2009, at 5:04 PM, Bruno Busco wrote:
Tim,if you do an export instead a checkout you could change the script you use to write the revision number in the svninfo.ftl file as it were written bythe ant svninfo task.In this way we will have both the svn copy of ofbiz and the hotwaxmedia demoexactly the same (no footer.ftl hacking). Thank you, -Bruno 2009/2/3 Tim Ruppert <[email protected]>Just wondering - what happens when you've done an export instead of a co?Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 ----- "Bruno Busco" <[email protected]> wrote:https://issues.apache.org/jira/browse/OFBIZ-1700?focusedCommentId=12586148 #action_12586148areBetter looking into this I am trying to implement a much simpler solution:I have changed the ant svninfo task to create a svninfo.xml file withall SVN info. It looks like this: -------------------------------------------------------------------- <?xml version="1.0"?> <info> <entry kind="dir" path="." revision="740301"> <url>https://svn.apache.org/repos/asf/ofbiz/trunk</url> <repository> <root>https://svn.apache.org/repos/asf</root> <uuid>13f79535-47bb-0310-9956-ffa450edef68</uuid> </repository> <wc-info> <schedule>normal</schedule> </wc-info> <commit revision="740301"> <author>buscob</author> <date>2009-02-03T13:26:11.171854Z</date> </commit> </entry> </info> --------------------------------------------------------------------I need now the ant task to extract the entry revision (and may be theurl) attributes from this file and append it into a simple text file that is included in the footer.ftl Does somebody know how to have an ant task read a tag attribute and then write it to a textfile? Many thanks, Bruno 2009/2/3 Jacques Le Roux <[email protected]>Thanks Bruno, Yes, like you I think we should consider more seriously this issue. Maybe your requirements (Subversion) inalready satisfied on the main demo server (please someone can answerhere) ? They are on my alternate dermo server. I just tested (mergedeasily)it works well. Some points though, bsh -> groovy, Some i18n needed in svninfo.txt One question : I don't think we should put this in hot-deploy,should we ?Jacques From: "Bruno Busco" <[email protected]>A patch is available in *OFBIZ-2164<https://issues.apache.org/jira/browse/OFBIZ-2164> * -Bruno* * 2009/2/3 Bruno Busco <[email protected]> OK, I will move to the footer.BTW for the SVN info, could we think to use the patch includedhere? *OFBIZ-1700 <https://issues.apache.org/jira/browse/OFBIZ-1700> * With this change a new ant target was added to run the svn infocommandand the results were available to be shown in an "about" application. May be now a better implementation could be to have the svn info generated string available in a portlet. WDYT? -Bruno ** 2009/2/2 Jacques Le Roux <[email protected]>+1 for footer (and if we could have the release number it would beevengreater ;o) Jacques From: "David E Jones" <[email protected]> Shouldn't that be the time the server thinks it is for the user,andtherefore something that we might want visible to the user justincase their time zone setting is off or something? Of course, it doesn't need to be in the header... I like thefooterbetter personally for less critical/useful info like that. -David On Feb 2, 2009, at 12:57 PM, Jacques Le Roux wrote: If we need information on the server there is the log inwebtools. Ican't see why an end user would be interested by server time,but Imay be wrong... Jacques From: "Bruno Busco" <[email protected]> On a second thought... are we sure this is not usefull to knowtheserver's time? If this is not the case and there are not objections I canremove it.-Bruno 2009/2/1 Bilgin Ibryam <[email protected]> In case my vote was not very clear: + 1 to remove itOn Feb 1, 2009, at 2:20 PM, Bilgin Ibryam wrote: + 1Bilgin On Feb 1, 2009, at 12:13 PM, Jacques Le Roux wrote: I just realise that we have a date/time in header. Does itmakesense to have this here ?Time (and even date) is not updated and each modern OSprovidesthis information in some taskbar anyway. Jacques
smime.p7s
Description: S/MIME cryptographic signature
