a big +1 to put more "social" pressure on contributors to provide and implement unit tests; it will be a big win when we all new code will be committed with unit tests, so I agree that it is the way to go but I just want to be realistic and enforcing this rule may have a big impact on the project (not all negative indeed). at the moment I would cast a -1 for making this rule mandatory; maybe we could enforce it as a condition to backport a fix to a release branch but I am not sure
But we should also review the toolset we have in OFBiz for unit tests, for example: 1) I dislike Minilang unit tests; we should ask for Groovy or Java tests 2) I don't like the fact that you have to add configuration to ofbiz-component.xml and testdef folder; we should instead stick to a more traditional usage of JUnit Jacopo On Oct 6, 2014, at 3:49 AM, Hans Bakker <[email protected]> wrote: > Good morning, > > If you are following the relatively new developments in software development > you will be aware of continuous integration or the next step: continuous > deployment. This is all part of the 'continuous improvement' principle. > When the OFBiz system was initially implemented this was already recognized > that automated tests are required for a quality product. > > Therefore my proposal that: > 1. New functions must have automated tests in the same commit in order to be > considered for the trunk. > 2. Existing functions which are extended will need a JUnit test the same as > new functions. > 3. The introduction of a test framework for on-line screens which can run in > batched mode. > 4. Reporting of an error should be done by providing an automated test which > shows the error. > > You might want to read an article I wrote on this subject with at the end > links to the originators of this principle: > https://www.linkedin.com/pulse/article/20140909060033-1227556-upgrade-your-erp-system-like-a-phone-app > > So please let me know what you think? > > Regards,Hans >
