-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11797/
-----------------------------------------------------------

(Updated June 28, 2013, 10:22 p.m.)


Review request for oozie.


Changes
-------

Virag's comments addressed. Changed SLACalculatorMemory.get() definition a bit, 
to fetch object related to history set jobId, when not found in map. Also 
edited and enhanced tests to check for actual times set in both cases of 
confirmWithDB Met/Miss


Bugs: OOZIE-1379
    https://issues.apache.org/jira/browse/OOZIE-1379


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1379


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 
1497884 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 1497884 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java
 1497884 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java
 1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 
1497884 
  trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1497884 
  trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 
1497884 
  trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 
1497884 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 
1497884 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java
 1497884 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
1497884 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 
1497884 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 
1497884 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 
1497884 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java
 1497884 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java
 1497884 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1497884 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java
 1497884 
  trunk/core/src/test/resources/coord-action-sla1.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/11797/diff/


Testing
-------

added unit test


Thanks,

Mona Chitnis

Reply via email to