> On June 25, 2013, 4:35 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java, > > line 117 > > <https://reviews.apache.org/r/11797/diff/8/?file=310679#file310679line117> > > > > also add prevStatus!=TerminalState > > > > It might happen that the workflow succeeds, so coord action succeeds > > but the coord job is not yet transitioned to success state. In this case, a > > coord_kill by user will generate a kill event even though the underlying > > workflow has succeeeded
This Coord Kill command is only loading actions which are non-terminal. Within the same command, it does not update action based on downstream workflow so why will this case occur? > On June 25, 2013, 4:35 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 339 > > <https://reviews.apache.org/r/11797/diff/8/?file=310690#file310690line339> > > > > Also need to set actualDuration. okay > On June 25, 2013, 4:35 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 342 > > <https://reviews.apache.org/r/11797/diff/8/?file=310690#file310690line342> > > > > This JPA executor doesn't update the start, end etc. Use > > SLASummaryUpdateForSLAStatusActualTimesJPAExecutor > > it will be good to have a testcase so such things are not missed > > thanks. adding lines in test case > On June 25, 2013, 4:35 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 705 > > <https://reviews.apache.org/r/11797/diff/8/?file=310690#file310690line705> > > > > if the coordinator goes from WAITING-> KILLED, then this condition will > > be true. > > Hence we need to set the startTime to null, and endTime to > > lastModifiedTime > > thanks and also added setting of actual start and end times for WF Job and Action at all times (because end_miss/end_met is being decided right after DB check and row updated in SLASummary) > On June 25, 2013, 4:35 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 741 > > <https://reviews.apache.org/r/11797/diff/8/?file=310690#file310690line741> > > > > if a JPA exception is thrown, the end event processed bit will be set, > > but neither MISS or MET event may be sent. > > There seems two ways to fix this > > 1) not set the event processed bit, so confirmWithDb will be called > > next time during periodic check > > 2) Problem with 1) is a rogue job may cause JPA execption many times. > > To avoid that, we can just send out a MISS event as anyways the current > > clock has passed the expected end. I also prefer option 2). thanks - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11797/#review22359 ----------------------------------------------------------- On June 25, 2013, 2:27 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11797/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 2:27 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1379 > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1496209 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1496209 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1496209 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 1496209 > trunk/core/src/test/resources/coord-action-sla1.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/11797/diff/ > > > Testing > ------- > > added unit test > > > Thanks, > > Mona Chitnis > >
