> On June 25, 2013, 3:27 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 731 > > <https://reviews.apache.org/r/11797/diff/8/?file=310690#file310690line731> > > > > If it is not a miss does not mean it is met. Logic still has issues
Actually not a issue. This can be dropped. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11797/#review22355 ----------------------------------------------------------- On June 25, 2013, 2:27 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11797/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 2:27 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1379 > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1496209 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1496209 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java > 1496209 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1496209 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1496209 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > 1496209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1496209 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 1496209 > trunk/core/src/test/resources/coord-action-sla1.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/11797/diff/ > > > Testing > ------- > > added unit test > > > Thanks, > > Mona Chitnis > >
