> On April 10, 2014, 6:18 p.m., Bowen Zhang wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 549 > > <https://reviews.apache.org/r/18257/diff/7/?file=554199#file554199line549> > > > > Cannot assume frequency is an integer. If the frequency is cron syntax, > > the code will break. Need to consider both cases for coord frequency.
Discussed same with Rohini, Her comment. "Changing both endtime and pausetime do not work with cron based frequencies as we deal with lastActionNumber. Can you create a sub task jira under the cron jira to support working with cron frequencies?" There were many places we assume frequency as integer, so it was a bigger task. we thought of going ahead and fix it later by creating JIRA( as it need to be fixed for many scenario). Not applicable now, I have changed the logic. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40051 ----------------------------------------------------------- On April 9, 2014, 11:57 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 11:57 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 5ecd5d5 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > d1c5752 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > fdc0a55 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
