----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40011 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72794> Changing both endtime and pausetime do not work with cron based frequencies as we deal with lastActionNumber. Can you create a sub task jira under the cron jira to support working with cron frequencies? core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72837> coordJob.resetPending(); core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72796> Should be in else {} block. resetMaterialization should also be in the else block. core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72802> What is the difference with testCoordChangeEndTimeDeleteAction. Just put a comment. core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72801> testCoordChangeEndTimeBeforeStart core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72800> testChangeTimeDeleteRunning - Rohini Palaniswamy On April 9, 2014, 11:57 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 11:57 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 5ecd5d5 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > d1c5752 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > fdc0a55 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
