> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, > > line 240 > > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line240> > > > > Why change this?
Because job start time is 2009-02-01T01:08Z, i have to pause it before start time to throw exception. > On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, > > line 220 > > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line220> > > > > Why change this? Because job start time is 2009-02-01T01:08Z, i have to pause it before start time to throw exception. > On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > lines 288-290 > > <https://reviews.apache.org/r/18257/diff/6/?file=552723#file552723line288> > > > > Why is this required? Should be able to set the nominal time as it is > > on the last action time lastactiontime and next materialization time = lastnominal time + frequency. > On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, > > lines 441-445 > > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line441> > > > > Please get action and assert not null. Don't have to assert fail in > > case of exception. Only if you have to assert on the exception type or > > message catch exceptions. junit will automatically fail the test if there > > is exception. It's just to check that action 2 is present and didn't get deleted. Function will throw exception if action is not found. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review39830 ----------------------------------------------------------- On April 8, 2014, 5:28 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 5:28 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 5ecd5d5 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > fdc0a55 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
