----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review39830 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72495> Needs to be reverted. You are now allowing a pausetime in past. core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72496> Why is this required? Should be able to set the nominal time as it is on the last action time core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72497> afterDate core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72508> It is not ok to remove this. Was added to address OOZIE-1632 core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72509> Changing core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72510> Why change this? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72511> Why change this? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72513> Please get action and assert not null. Don't have to assert fail in case of exception. Only if you have to assert on the exception type or message catch exceptions. junit will automatically fail the test if there is exception. core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment72515> Can we combine this testcase with testCoordActionDelete as most of the code is duplicated. i.e assert for endtime and pausetime in the same test. - Rohini Palaniswamy On April 8, 2014, 5:28 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 5:28 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 5ecd5d5 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > fdc0a55 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
