----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38088/#review99278 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java (line 41) <https://reviews.apache.org/r/38088/#comment156184> Why do u need console.url. You can construct it from others properties. core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java (line 50) <https://reviews.apache.org/r/38088/#comment156189> wf.superparent.id core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java (line 129) <https://reviews.apache.org/r/38088/#comment156187> I don't think parentConf will ever have SUPER_PARENT_ID. parentConf is jobConf. core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java (line 189) <https://reviews.apache.org/r/38088/#comment156186> context.getWorkflow().getId() => this should be context.getWorkflow().getParentId() core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java (line 186) <https://reviews.apache.org/r/38088/#comment156190> It should be parent id not name. - Purshotam Shah On Sept. 11, 2015, 7:07 a.m., Akshay Rai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38088/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 7:07 a.m.) > > > Review request for oozie, Purshotam Shah and Robert Kanter. > > > Bugs: OOZIE-2346 > https://issues.apache.org/jira/browse/OOZIE-2346 > > > Repository: oozie-git > > > Description > ------- > > Add super parent id and workflow depth information along with the other oozie > job information into the job conf. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > ceaef8b > > Diff: https://reviews.apache.org/r/38088/diff/ > > > Testing > ------- > > Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 > --reset-scm > > +1 PATCH_APPLIES > +1 CLEAN > +1 RAW_PATCH_ANALYSIS > +1 the patch does not introduce any @author tags > +1 the patch does not introduce any tabs > +1 the patch does not introduce any trailing spaces > +1 the patch does not introduce any line longer than 132 > +1 the patch does adds/modifies 1 testcase(s) > +1 RAT > +1 the patch does not seem to introduce new RAT warnings > +1 JAVADOC > +1 the patch does not seem to introduce new Javadoc warnings > WARNING: the current HEAD has 91 Javadoc warning(s) > +1 COMPILE > +1 HEAD compiles > +1 patch compiles > +1 the patch does not seem to introduce new javac warnings > +1 BACKWARDS_COMPATIBILITY > +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient > annotations > +1 the patch does not modify JPA files > -1 TESTS > Tests run: 1689 > Tests failed: 3 > Tests errors: 0 > > The patch failed the following testcases: > > testHostname(org.apache.oozie.servlet.TestHostnameFilter) > > testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) > > testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) > > +1 DISTRO > +1 distro tarball builds with the patch > > ---------------------------- > -1 Overall result, please check the reported -1(s) > > > The test failures are not related to the fix. > > > Thanks, > > Akshay Rai > >
