> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line > > 106 > > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106> > > > > Why are you adding CONSOLE_URL? I don't see any use of adding static > > CONSOLE_URL for each job. > > Akshay Rai wrote: > Firstly, schedulers like azkaban inject the completet url of the job into > the conf. > > For a job scheduled on oozie it is not possible to get the link to the > job unless we know the console url. > > In the oozie-default.xml file there is a property > 'oozie.JobCommand.job.console.url' which holds the base console url for a > worklfow job but this isn't injected into the job conf. > > Purshotam Shah wrote: > Your console URL will look like > "http://host:port/proxy/application_1444287091929_370807/". > From job conf you can get "mapreduce.jobtracker.address" and and > construct console url. > We will be setting ooozie job info to job conf. Don't u think that it > will be duplicate entry. > I am just try to avoid duplicate entries ( if we can compute it somwhow).
Sorry for the delay. I really don't know why I am not receiving any email notifications for any updates on my rb apart from myself even after enabling it. Anyway, coming back to the topic, I am afraid there is some misunderstanding here. The console url I am referring to is the oozie job console url which looks like this http://localhost:11000/oozie?job=0000217-150708230502772-oozie-oozi-W A snapshot from oozie-default.xml ```html <property> <name>oozie.JobCommand.job.console.url</name> <value>${oozie.base.url}?job=</value> </property> <property> <name>oozie.base.url</name> <value>http://localhost:11000/oozie</value> <description> Base Oozie URL. </description> </property> ``` To construct this url there is no property in the job conf which can be used. Now, there are 2 ways of injecting this info 1. Inject the complete oozie job url like the one I mentioned in the above para into the job conf. But there is a problem with this approach. That is, to maintain consistency we may have to inject the complete url to the super parent and the coordinator as well which seems like many duplicates. 2. Inject only the base console url separately. Now using this base console url and the ids to the job, super parent and coordinator, the complete urls can be constructed. - Akshay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38088/#review101532 ----------------------------------------------------------- On Oct. 19, 2015, 6:50 a.m., Akshay Rai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38088/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 6:50 a.m.) > > > Review request for oozie, Purshotam Shah and Robert Kanter. > > > Bugs: OOZIE-2346 > https://issues.apache.org/jira/browse/OOZIE-2346 > > > Repository: oozie-git > > > Description > ------- > > Add super parent id and workflow depth information along with the other oozie > job information into the job conf. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2 > core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452 > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 98f356e > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > ceaef8b > > Diff: https://reviews.apache.org/r/38088/diff/ > > > Testing > ------- > > Tested locally by running a subworkflow with and without a coordinator. > > > Thanks, > > Akshay Rai > >
