> On Oct. 5, 2015, 9:15 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line > > 106 > > <https://reviews.apache.org/r/38088/diff/8/?file=1088413#file1088413line106> > > > > Why are you adding CONSOLE_URL? I don't see any use of adding static > > CONSOLE_URL for each job.
Firstly, schedulers like azkaban inject the completet url of the job into the conf. For a job scheduled on oozie it is not possible to get the link to the job unless we know the console url. In the oozie-default.xml file there is a property 'oozie.JobCommand.job.console.url' which holds the base console url for a worklfow job but this isn't injected into the job conf. On Oct. 5, 2015, 9:15 p.m., Akshay Rai wrote: > > minor comment... Rest looks good. Remove CONSOLE_URL. Thanks Purshotam for the review. I have one question. I see that the coordinator Id also needs a change as it doesn't inject the right coord id for a subworkflow. Shall I make the change in the same rb or should I create a separate one? - Akshay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38088/#review101532 ----------------------------------------------------------- On Oct. 1, 2015, 4:54 p.m., Akshay Rai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38088/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 4:54 p.m.) > > > Review request for oozie, Purshotam Shah and Robert Kanter. > > > Bugs: OOZIE-2346 > https://issues.apache.org/jira/browse/OOZIE-2346 > > > Repository: oozie-git > > > Description > ------- > > Add super parent id and workflow depth information along with the other oozie > job information into the job conf. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/WorkflowJob.java e2ad6f2 > core/src/main/java/org/apache/oozie/WorkflowJobBean.java ef1f452 > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > ceaef8b > > Diff: https://reviews.apache.org/r/38088/diff/ > > > Testing > ------- > > Tested locally by running a subworkflow with and without a coordinator. > > > Thanks, > > Akshay Rai > >
