> On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java, > > line 189 > > <https://reviews.apache.org/r/38088/diff/5/?file=1068130#file1068130line189> > > > > context.getWorkflow().getId() => this should be > > context.getWorkflow().getParentId()
If you look at the injectParent call just before this, you will see that we are injecting the current workflow id into the subworkflow's configuration. So the current workflow id is the immediate parent id to the subworkflow. Similarly while injecting the super parent id, the super parent for the subworkflow will be 1. Its immediate parent id, if the subworkflow is at depth 1. 2. Else it will be the super parent id that we injected into the parent conf. > On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 50 > > <https://reviews.apache.org/r/38088/diff/5/?file=1068129#file1068129line50> > > > > wf.superparent.id I will make this change. > On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java, > > line 129 > > <https://reviews.apache.org/r/38088/diff/5/?file=1068130#file1068130line129> > > > > I don't think parentConf will ever have SUPER_PARENT_ID. parentConf is > > jobConf. When the start method is called(line 155) for a subworkflow at depth 1, the parentConf will not have a super parent id. That is when I will inject the immediate parent id into the subworkflow's job conf as the SUPER_PARENT_ID. So for subworkflows at depth 2 onwards, the SUPER_PARENT_ID will be available in the parentConf. > On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java, > > line 186 > > <https://reviews.apache.org/r/38088/diff/5/?file=1068131#file1068131line186> > > > > It should be parent id not name. Will fix this. > On Sept. 16, 2015, 7:39 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java, line 41 > > <https://reviews.apache.org/r/38088/diff/5/?file=1068129#file1068129line41> > > > > Why do u need console.url. You can construct it from others properties. None of the properties in the job conf have the console url. - Akshay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38088/#review99278 ----------------------------------------------------------- On Sept. 11, 2015, 7:07 a.m., Akshay Rai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38088/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 7:07 a.m.) > > > Review request for oozie, Purshotam Shah and Robert Kanter. > > > Bugs: OOZIE-2346 > https://issues.apache.org/jira/browse/OOZIE-2346 > > > Repository: oozie-git > > > Description > ------- > > Add super parent id and workflow depth information along with the other oozie > job information into the job conf. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 4b13daa > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > ceaef8b > > Diff: https://reviews.apache.org/r/38088/diff/ > > > Testing > ------- > > Result of running test-patch locally: bin/test-patch --JIRA=OOZIE-2346 > --reset-scm > > +1 PATCH_APPLIES > +1 CLEAN > +1 RAW_PATCH_ANALYSIS > +1 the patch does not introduce any @author tags > +1 the patch does not introduce any tabs > +1 the patch does not introduce any trailing spaces > +1 the patch does not introduce any line longer than 132 > +1 the patch does adds/modifies 1 testcase(s) > +1 RAT > +1 the patch does not seem to introduce new RAT warnings > +1 JAVADOC > +1 the patch does not seem to introduce new Javadoc warnings > WARNING: the current HEAD has 91 Javadoc warning(s) > +1 COMPILE > +1 HEAD compiles > +1 patch compiles > +1 the patch does not seem to introduce new javac warnings > +1 BACKWARDS_COMPATIBILITY > +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient > annotations > +1 the patch does not modify JPA files > -1 TESTS > Tests run: 1689 > Tests failed: 3 > Tests errors: 0 > > The patch failed the following testcases: > > testHostname(org.apache.oozie.servlet.TestHostnameFilter) > > testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) > > testStreamingConfOverride(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) > > +1 DISTRO > +1 distro tarball builds with the patch > > ---------------------------- > -1 Overall result, please check the reported -1(s) > > > The test failures are not related to the fix. > > > Thanks, > > Akshay Rai > >
