Greg --
You don't have to break everything to be famous, all you have
to do is slow things down a lot. The article that is at the root of this issue
rejected UUIDs because comparisons are slow due to their length. Could you try
some operations with your fix and the large DB and compare performance?
Saludos, Roger
From: [email protected] [mailto:[email protected]] On Behalf Of Greg Warren
Sent: Friday, September 16, 2011 1:06 AM
To: [email protected]
Subject: [OPENMRS-DEV] TRUNK-2362 - Get rid of implementations of equals and
hashCode in our domain objects
I am going to check in this fix which affects almost all the domain objects.
We have removed the equals and hashcode methods from every class so objects
will check the uuid for equality from the BaseOpenmrsObject equals method.
Previously, object equality was usually based on id or other data so for
example, new User(1) would be equal to new User(1) or userList.contains(new
User(1)) might find a matching user.
This will not be true unless the objects have equal uuids so everyone should be
aware of that change.
Please keep an eye out for any issues that might need to be fixed. Hopefully
this will not cause too much trouble.
I don't want to be forever known as 'The guy that caused all those defects with
that one big check-in' :)
________________________________
Click here to
unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list
_________________________________________
To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to
[email protected] with "SIGNOFF openmrs-devel-l" in the body (not
the subject) of your e-mail.
[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
