FWIW, I saw a decent amount of time held up in casting new Strings when gathering UUIDs from the db in the last profiling I ran (probably something to do with Sync Module looking up UUIDs for concepts when saving observations). I don't know what the cost of casting Strings is, but it has to be more than converting int -> Integer.
Jeremy Keiper OpenMRS Core Developer AMPATH / IU-Kenya Support On Fri, Sep 16, 2011 at 8:05 PM, Darius Jazayeri <[email protected]>wrote: > We're not changing the hibernate identity field (that will still be the > integer primary key). Rather we are changing the identity in _java_. I.e. we > are only changing the behavior of the equals and hashcode methods, and thus > the behavior of set membership in java in some corner cases. > > Also, uuids will now be assigned when you instantiate a new object. So > anyone who is counting on this sort of code in a module will need to change > it: > ConceptService.getConcept(5).equals (new Concept (5)) > > -Darius (by phone) > > On Sep 16, 2011 12:18 PM, "Dave Thomas" <[email protected]> wrote: > > While we're at it, can we change cohorts to use uuids rather than patient > ids too? > > > > On Sep 16, 2011 5:56 PM, "Friedman, Roger (CDC/CGH/DGHA) (CTR)" < > [email protected]> wrote: > > The origin... > > > On Sep 16, 2011 7:14 AM, "Friedman, Roger (CDC/CGH/DGHA) (CTR)" < > [email protected]<mailto:[email protected]>... > > From: [email protected]<mailto:[email protected]> [mailto:[email protected] > <mailto:[email protected]>] On Behalf Of Greg Warren > > > > Sent: Friday, September 16, 2011 1:06 AM > > To: [email protected]<mailto: > [email protected]> > > > > Subject: [OPENMRS-DEV] TRUNK-2362 - Get rid of implementations of equals > and hashCode in our doma... > > Click here to > > unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> > from OpenMRS Developers' mailing list > > > > _________________________________________ > > > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > [email protected] with "SIGNOFF openmrs-devel-l" in the body > (not the subject) of your e-mail. > > > > [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] > > ________________________________ > Click here to unsubscribe from OpenMRS Developers' mailing list > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
