yurytch commented on a change in pull request #134: URL: https://github.com/apache/openoffice/pull/134#discussion_r707002989
########## File path: main/configure.ac ########## @@ -4392,7 +4449,7 @@ _ACEOF cat saxontest.java >&5 AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon jar]) fi -elif test "x$enable_saxon" = "xyes"; then +elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" != "xno"; then Review comment: > In this patch, not indicating explicitly one setting is considered as disabling it explicitly. This patch deals only partially with the behaviour of `--enable-category-b` option, namely that specifying `--disable-category-b` voids any subsequent selective enabling of the category-b parts. Therefore there are indeed more of such modifications in the `configure.ac` to make, for someone more knowledgeable than me. In my local copy I also have `saxon` explicitly selectable, but also `graphite`, `javascript`, and `coinmp`. There are more `category-b` parts in the `configure.ac`, if I remember right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org