yurytch commented on a change in pull request #134: URL: https://github.com/apache/openoffice/pull/134#discussion_r716096995
########## File path: main/configure.ac ########## @@ -4392,7 +4449,7 @@ _ACEOF cat saxontest.java >&5 AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon jar]) fi -elif test "x$enable_saxon" = "xyes"; then +elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" != "xno"; then Review comment: Arrigo, you seem to miss (or skip over) the way `--enable-saxon` option actually works (and likewise its counterparts for other category-b members). The option does NOT work i.e. has **no effect** if `--disable-category-b` option is also given. So one can't disable category-b components as a group and still enable separate components. I didn't want to touch that part of configure code, so I added `enable_saxon_explicit` variable to work around the problem. I sort of strengthened `--enable-saxon`'s effect (likewise for its counterparts for other category-b members). If it broke selective DISabling saxon when enable-category-b is also given, then we should look at how to strengthen the disabling part of the code -- because your patch looks like it effectively brings back the original AC behaviour, before MY patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org