ardovm commented on a change in pull request #134:
URL: https://github.com/apache/openoffice/pull/134#discussion_r715875164
##########
File path: main/configure.ac
##########
@@ -4392,7 +4449,7 @@ _ACEOF
cat saxontest.java >&5
AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon
jar])
fi
-elif test "x$enable_saxon" = "xyes"; then
+elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" !=
"xno"; then
Review comment:
IMHO a variable that is named `enable_saxon_explicit` should be set when
we "explicitly" indicate `--enable-saxon`.
I suggested to use another variable `disable_saxon_explicit`, that should be
set when we "explicitly" indicate `--disable-saxon` but it would also work to
use `enable_saxon_explicit="no"`, as you suggest.
If we do not either enable or disable something explicitly, then we may
enable it "implicitly" by means of `--enable-category-b` or disable it
implicitly by means of `--disable-category-b`.
When it's time to understand if saxon has to be enabled or not, the logic
should be:
1. was it either enabled or disabled explicitly? If so, enable or disable it.
2. was it enabled implicitly? If so, enable it.
3. Otherwise disable it.
With your last comment, you seem to be getting close to this, but I do not
understand what you mean by "explicit".
I hope I could explain well what _I_ would mean. I hope it makes sense to
you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
