yurytch commented on a change in pull request #134:
URL: https://github.com/apache/openoffice/pull/134#discussion_r709431778



##########
File path: main/configure.ac
##########
@@ -4392,7 +4449,7 @@ _ACEOF
           cat saxontest.java >&5
           AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon 
jar])
         fi
-elif test "x$enable_saxon" = "xyes"; then
+elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" != 
"xno"; then

Review comment:
       If I (finally) get you right, you are saying that my patch breaks 
`--enable-category-b` behaviour. 
   My apologies.
   However, the fix should go like that, then:
   
   `+if \( test -n "$enable_saxon" && test "$enable_saxon" != "no" \) -o 
"$enable_category_b" = "yes" ; then`
   
   for every equivalent string in the 1st part of the patch.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to