ardovm commented on a change in pull request #134:
URL: https://github.com/apache/openoffice/pull/134#discussion_r709355648
##########
File path: main/configure.ac
##########
@@ -4392,7 +4449,7 @@ _ACEOF
cat saxontest.java >&5
AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon
jar])
fi
-elif test "x$enable_saxon" = "xyes"; then
+elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" !=
"xno"; then
Review comment:
> > @yurytch are you able to update this PR per Arrigo's comments?
>
> The change in the Arrigo's comment looks wrong to me.
Yes, it was not meant to be applied verbatim. It was just a suggestion about
how variables could be named.
I am sorry if I led you to think otherwise.
> My patch deals with ONE specific problem, how to enable category-b
components piece by piece, even if category-b itself is disabled (the previous
behaviour was that enable directives for category-b components have no effect
in this case).
> So I added those additional configure directives, kind of 'on top' of the
existing AC code.
> Arrigo talks about something else, but his change does not seem to address
HIS issue, it tweaks MY solution, and it looks that it breaks it.
>
> Maybe I just don't understand the issue well enough.
I wanted to point out that your patch changes the current behavior when the
only `--enable-category-b` parameter is given.
In my humble opinion, your patch should add choices, but not change the
behavior of currently available parameters. So instead of disabling all
"category b" parameters by default, you could rather enable them, and add
switches to disable each of them explicitly. Such switches could set variables
named `disable_xxx_explicit`.
I hope it is more clear now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
