Hmm, I found the next issue with the TCK: The TCK assumes that interception is implemented via inheritance, but we implement it via proxying. org.jboss.cdi.tck.interceptors.tests.contract.interceptorLifeCycle.Intercep torLifeCycleTest accesses public fields of a @Dependent bean (Warrior.weapon1 and Warrior.weapon2)
In our case they are null, because it is a proxy. I’ll create a TCK ticket for it. Cheers, Arne Am 30.06.14 18:55 schrieb "Arne Limburg" unter <[email protected]>: >Yes, I just committed the fix. > >I am now on InterceptorBindingOverridingTest > >Am 30.06.14 17:57 schrieb "Mark Struberg" unter <[email protected]>: > >>Indeed, weird but seems to be ok from the wording. >> >>This was pretty sketchy defined in cdi-1.0 but we can work with this. >> >>LieGrue, >>strub >> >> >>On Monday, 30 June 2014, 9:23, Arne Limburg >><[email protected]> wrote: >> >> >>> >>> >>>Hmm, read the spec twice and I am afraid, our understanding was wrong. >>>In >>>11.4 it says that every method of every super type should be returned. >>>Since we rely on AnnotatedType#getMethod to return only relevant ones, >>>this is a bigger rework :( >>>I’ll take it and see, what I can do. >>> >>>Cheers, >>>Arne >>> >>> >>>Am 30.06.14 09:13 schrieb "Romain Manni-Bucau" unter >>><[email protected]>: >>> >>> >>>>If you are on it please do otherwise I'll check tonight. >>>> >>>> >>>>Romain Manni-Bucau >>>>Twitter: @rmannibucau >>>>Blog: http://rmannibucau.wordpress.com/ >>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>Github: https://github.com/rmannibucau >>>> >>>> >>>>2014-06-30 9:07 GMT+02:00 Arne Limburg <[email protected]>: >>>>> As Mark says, this is NOT defined anywhere in the spec. >>>>> I guess, this is a weld issue since they don¹t handle inheritance in >>>>> AnnotatedTypes correctly. >>>>> >>>>> So, who creates a CDITCK ticket for it? >>>>> >>>>> Am 30.06.14 08:37 schrieb "Romain Manni-Bucau" unter >>>>> <[email protected]>: >>>>> >>>>> >>>>>>basically >>>>>>http://grepcode.com/file/repository.jboss.org/nexus/content/repositor >>>>>>i >>>>>>es >>>>>>/r >>>>>>eleases/org.jboss.cdi.tck/cdi-tck-impl/1.2.0.Beta1/org/jboss/cdi/tck/ >>>>>>t >>>>>>es >>>>>>ts >>>>>>/extensions/beanManager/beanAttributes/Dam.java?av=f >>>>>>and >>>>>>http://grepcode.com/file/repository.jboss.org/nexus/content/repositor >>>>>>i >>>>>>es >>>>>>/r >>>>>>eleases/org.jboss.cdi.tck/cdi-tck-impl/1.2.0.Beta1/org/jboss/cdi/tck/ >>>>>>t >>>>>>es >>>>>>ts >>>>>>/extensions/beanManager/beanAttributes/Lake.java?av=f >>>>>>but >>>>>>http://grepcode.com/file/repository.jboss.org/nexus/content/repositor >>>>>>i >>>>>>es >>>>>>/r >>>>>>eleases/org.jboss.cdi.tck/cdi-tck-impl/1.2.0.Beta1/org/jboss/cdi/tck/ >>>>>>t >>>>>>es >>>>>>ts >>>>>>/extensions/beanManager/beanAttributes/CreateBeanAttributesTest.java# >>>>>>C >>>>>>re >>>>>>at >>>>>>eBeanAttributesTest.testBeanAttributesForMethod%28%29 >>>>>>expects to get both getFish methods >>>>>> >>>>>> >>>>>>Romain Manni-Bucau >>>>>>Twitter: @rmannibucau >>>>>>Blog: http://rmannibucau.wordpress.com/ >>>>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>Github: https://github.com/rmannibucau >>>>>> >>>>>> >>>>>>2014-06-30 8:12 GMT+02:00 Mark Struberg <[email protected]>: >>>>>>> CDI-1.1 does not require this. If the TCK tests this, then the test >>>>>>>needs to be challenged. >>>>>>> >>>>>>> LieGrue, >>>>>>> strub >>>>>>> >>>>>>> On Monday, 30 June 2014, 7:44, Romain Manni-Bucau >>>>>>><[email protected]> wrote: >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>CDI 1.1 wants parents methods with different qualifiers in >>>>>>>>at.getMethods() IIRC. >>>>>>>> >>>>>>>> >>>>>>>>Romain Manni-Bucau >>>>>>>>Twitter: @rmannibucau >>>>>>>>Blog: http://rmannibucau.wordpress.com/ >>>>>>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>>>Github: https://github.com/rmannibucau >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>2014-06-30 7:25 GMT+02:00 Arne Limburg >>>>>>>><[email protected]>: >>>>>>>>> @Inject does not have a new version for now (and probably will >>>>>>>>>never >>>>>>>>>have) >>>>>>>> >>>>> >>> >>> >>> >
