CDI 1.1 wants parents methods with different qualifiers in at.getMethods() IIRC.


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-06-30 7:25 GMT+02:00 Arne Limburg <[email protected]>:
> @Inject does not have a new version for now (and probably will never have).
>
> You implemented isOverridden such that it returns true only if all
> annotations of sub- and super-method are the same (excluding lifecycle-
> and interceptor-methods). What was the reason behind that? In the
> @Inject-TCK methods are overridden to remove qualifiers, which is now
> broken.
>
> Am 30.06.14 07:19 schrieb "Romain Manni-Bucau" unter
> <[email protected]>:
>
>
>>well not sure I can before tonight. BTW new tcks replaces older no?
>>Know in bval they broke the tcks but that is intended
>>
>>
>>Romain Manni-Bucau
>>Twitter: @rmannibucau
>>Blog: http://rmannibucau.wordpress.com/
>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>Github: https://github.com/rmannibucau
>>
>>
>>2014-06-30 7:17 GMT+02:00 Arne Limburg <[email protected]>:
>>> Yes, the @Inject-TCK runs with profile jsr330-tck
>>>
>>> Btw.: It are the changes in AnnotatedTypeImpl#isOverridden that break
>>>it.
>>> Do you take a look at it or shall I?
>>>
>>> Am 30.06.14 07:12 schrieb "Romain Manni-Bucau" unter
>>> <[email protected]>:
>>>
>>>
>>>>Is there another profile?
>>>>
>>>>
>>>>Romain Manni-Bucau
>>>>Twitter: @rmannibucau
>>>>Blog: http://rmannibucau.wordpress.com/
>>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>Github: https://github.com/rmannibucau
>>>>
>>>>
>>>>2014-06-30 7:10 GMT+02:00 Arne Limburg <[email protected]>:
>>>>> And countingÅ 
>>>>>
>>>>> But we broke the @Inject-TCK :(
>>>>> It was the commit for OWB-979 (R1606380)
>>>>> I see, what I can do about it.
>>>>>
>>>>> Cheers,
>>>>> Arne
>>>>>
>>>>>
>>>>> Am 29.06.14 21:59 schrieb "Mark Struberg" unter <[email protected]>:
>>>>>
>>>>>>we are now down to 38 failing tests.
>>>>>>
>>>>>>Txs Romain and Arne!
>>>>>>
>>>>>>gn8 and LIeGrue,
>>>>>>strub
>>>>>>
>>>>>>
>>>>>>On Saturday, 28 June 2014, 12:18, Mark Struberg <[email protected]>
>>>>>>wrote:
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>This has to do how surefire counts such tests.
>>>>>>>
>>>>>>>If you run them in the IDE you will see the correct stats.
>>>>>>>
>>>>>>>Running single unit tests in Idea I always use a little
>>>>>>>debug-suite.xml
>>>>>>>which I configure for the testng runner:
>>>>>>>
>>>>>>>
>>>>>>>----
>>>>>>><suite name="JSR-346-TCK debug" verbose="2"
>>>>>>>configfailurepolicy="continue">
>>>>>>>    <test name="JSR-346 TCK debug">
>>>>>>>        <groups>
>>>>>>>            <run>
>>>>>>>                <exclude name="integration" />
>>>>>>>                <exclude name="javaee-full" />
>>>>>>>            </run>
>>>>>>>        </groups>
>>>>>>>
>>>>>>>        <packages>
>>>>>>>            <!--
>>>>>>>            <package name="org.jboss.cdi.tck.tests.*">
>>>>>>>                <include
>>>>>>>name="org.jboss.cdi.tck.tests.context.alterable"/>
>>>>>>>                <include
>>>>>>>name="org.jboss.cdi.tck.tests.implementation.producer.field.definitio
>>>>>>>n"
>>>>>>>/>
>>>>>>>                <include
>>>>>>>name="org.jboss.cdi.tck.tests.implementation.disposal.method.definiti
>>>>>>>on
>>>>>>>.b
>>>>>>>roken.unresolvedMethod"/>
>>>>>>>                <include
>>>>>>>name="org.jboss.cdi.tck.tests.implementation.disposal.method.definiti
>>>>>>>on
>>>>>>>.b
>>>>>>>roken.validation.ambiguous"/>
>>>>>>>                <include
>>>>>>>name="org.jboss.cdi.tck.tests.implementation.disposal.method.definiti
>>>>>>>on
>>>>>>>.b
>>>>>>>roken.interceptor"/>
>>>>>>>            </package>
>>>>>>>            -->
>>>>>>>        </packages>
>>>>>>>
>>>>>>>        <classes>
>>>>>>>            <class
>>>>>>>name="org.jboss.cdi.tck.tests.context.alterable.AlterableContextTest"
>>>>>>>>
>>>>>>><!--
>>>>>>>                <methods>
>>>>>>>                    <include
>>>>>>>name="testNothingHappensIfNoInstanceToDestroy"/>
>>>>>>>                </methods>
>>>>>>>-->
>>>>>>>            </class>
>>>>>>>        </classes>
>>>>>>>    </test>
>>>>>>>
>>>>>>></suite>
>>>>>>>
>>>>>>>
>>>>>>>----
>>>>>>>
>>>>>>>LieGrue,
>>>>>>>strub
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> On Saturday, 28 June 2014, 11:56, Romain Manni-Bucau
>>>>>>>><[email protected]> wrote:
>>>>>>>> > Hi Mark
>>>>>>>>
>>>>>>>> I have:
>>>>>>>>
>>>>>>>> Tests run: 1167, Failures: 158, Errors: 0, Skipped: 250
>>>>>>>>
>>>>>>>> What do I miss?
>>>>>>>>
>>>>>>>> BTW I should get few cycle to help tonight (or this afternoon)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Romain Manni-Bucau
>>>>>>>> Twitter: @rmannibucau
>>>>>>>> Blog: http://rmannibucau.wordpress.com/
>>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>>>> Github: https://github.com/rmannibucau
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> 2014-06-28 10:27 GMT+02:00 Mark Struberg <[email protected]>:
>>>>>>>>
>>>>>>>>>  current state after yesterday nights hacking: we are at just 66
>>>>>>>>>broken TCK
>>>>>>>>>  tests left from almost 1000.
>>>>>>>>>  C'm on guys, could need some help!
>>>>>>>>>
>>>>>>>>>  LieGrue,
>>>>>>>>>  strub
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>  > On Saturday, 7 June 2014, 7:56, Mark Struberg
>>>>>>>> <[email protected]> wrote:
>>>>>>>>>  > > Hi!
>>>>>>>>>  >
>>>>>>>>>  > I've upgraded trunk to the latest CDI-1.2 TCK test and did all
>>>>>>>>>the
>>>>>>>>>  necessary
>>>>>>>>>  > configuration.
>>>>>>>>>  >
>>>>>>>>>  > I started with passing 134 tests and am not at 732. Still a few
>>>>>>>>>miles
>>>>>>>> to
>>>>>>>>>  go
>>>>>>>>>  > though...
>>>>>>>>>  >
>>>>>>>>>  > LieGrue,
>>>>>>>>>  > strub
>>>>>>>>>  >
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>
>

Reply via email to