dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r782554792
##########
File path: c++/src/Reader.cc
##########
@@ -41,6 +41,8 @@ namespace orc {
"1.6.0", "1.6.1", "1.6.2", "1.6.3", "1.6.4", "1.6.5", "1.6.6", "1.6.7",
"1.6.8",
"1.6.9", "1.6.10", "1.6.11", "1.7.0"};
+ static const RowReaderOptions::IdReadIntentMap EMPTY_ID_READ_INTENT_MAP;
Review comment:
Actually, when I test this PR on my Mac. `Clang 13` complains with
`declaration requires an exit-time destructor` and this is a regression
although this is a warning. Could you try `Clang 13` and remove the warning?
```
$ make package
[ 5%] Built target snappy_ep
[ 11%] Built target zlib_ep
[ 17%] Built target zstd_ep
[ 23%] Built target lz4_ep
[ 29%] Built target googletest_ep
[ 35%] Built target protobuf_ep
Consolidate compiler generated dependencies of target orc
[ 35%] Building CXX object c++/src/CMakeFiles/orc.dir/Reader.cc.o
/Users/dongjoon/APACHE/orc-merge/c++/src/Reader.cc:44:50: error: declaration
requires an exit-time destructor [-Werror,-Wexit-time-destructors]
static const RowReaderOptions::IdReadIntentMap EMPTY_ID_READ_INTENT_MAP;
^
/Users/dongjoon/APACHE/orc-merge/c++/src/Reader.cc:44:50: error: declaration
requires a global destructor [-Werror,-Wglobal-constructors]
2 errors generated.
make[2]: *** [c++/src/CMakeFiles/orc.dir/Reader.cc.o] Error 1
make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
make: *** [all] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
