dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r781667552
##########
File path: c++/include/orc/Reader.hh
##########
@@ -149,6 +149,25 @@ namespace orc {
*/
RowReaderOptions& includeTypes(const std::list<uint64_t>& types);
+ /**
+ * A map type of <typeId, ReadIntent>.
+ */
+ typedef std::map<uint64_t, ReadIntent> TypeReadIntents;
Review comment:
Maybe, `TypeReadIntents` -> `IdReadIntentMap` sounds better because we
use the following in this file.
```cpp
std::map<std::string, uint64_t> nameIdMap;
std::map<uint64_t, const Type*> idTypeMap;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
