dongjoon-hyun commented on a change in pull request #990: URL: https://github.com/apache/orc/pull/990#discussion_r781679742
########## File path: c++/src/Reader.hh ########## @@ -88,10 +88,12 @@ namespace orc { // Select a field by id void updateSelectedByFieldId(std::vector<bool>& selectedColumns, uint64_t fieldId); // Select a type by id - void updateSelectedByTypeId(std::vector<bool>& selectedColumns, uint64_t typeId); + void updateSelectedByTypeId(std::vector<bool>& selectedColumns, uint64_t typeId, + const RowReaderOptions::TypeReadIntents* readIntents = nullptr); Review comment: Shall we use reference instead of pointer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org