rizaon commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r782517663
##########
File path: c++/include/orc/Common.hh
##########
@@ -122,6 +122,19 @@ namespace orc {
StreamKind_BLOOM_FILTER_UTF8 = 8
};
+ /**
+ * Specific read intention when selecting a certain TypeId.
+ * This enum currently only being utilized by LIST type selection.
+ *
+ * TODO: extend this to support MAP and UNION type.
Review comment:
Removed the TODO. I will file a follow-up JIRA after this PR merged.
##########
File path: c++/include/orc/Reader.hh
##########
@@ -149,6 +149,25 @@ namespace orc {
*/
RowReaderOptions& includeTypes(const std::list<uint64_t>& types);
+ /**
+ * A map type of <typeId, ReadIntent>.
+ */
+ typedef std::map<uint64_t, ReadIntent> TypeReadIntents;
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]