dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r781680290
##########
File path: c++/test/TestReader.cc
##########
@@ -137,4 +139,89 @@ namespace orc {
CheckFileWithSargs("bad_bloom_filter_1.6.11.orc", "ORC C++ 1.6.11");
CheckFileWithSargs("bad_bloom_filter_1.6.0.orc", "ORC C++");
}
+
+ /**
+ * Read complextypes_iceberg.orc and verify the resolved selections.
+ *
+ * The ORC file has the following schema:
+ * struct<
+ * id:bigint,
+ * int_array:array<int>,
+ * int_array_array:array<array<int>>,
+ * int_map:map<string,int>,
+ * int_map_array:array<map<string,int>>,
+ * nested_struct:struct<
+ * a:int,
+ * b:array<int>,
+ * c:struct<
+ * d:array<array<struct<
+ * e:int,
+ * f:string
+ * >>>
+ * >,
+ * g:map<string,struct<
+ * h:struct<
+ * i:array<double>
+ * >
+ * >>
+ * >
+ * >
+ *
+ * @param readIntents TypeReadIntents describing the section.
+ * @param expectedSelection expected TypeIds that will be selected from given
+ * readIntents.
+ */
+ void verifySelection(const RowReaderOptions::TypeReadIntents &readIntents,
+ const std::vector<uint32_t> &expectedSelection) {
+ std::string fileName = "complextypes_iceberg.orc";
Review comment:
Shall we remove `_iceberg` part of this test case file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
