[
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296063#comment-17296063
]
ASF GitHub Bot commented on PARQUET-1992:
-----------------------------------------
andersonm-ibm opened a new pull request #877:
URL: https://github.com/apache/parquet-mr/pull/877
This PR is one of the options to solve the problem "Cannot build from
tarball because of git submodules".
1. encryption interop tests run separately from unit tests - in
integration-test phase
2. Files for interop tests are downloaded using git submodules in ci-test
maven profile only
- `mvn package/install` - doesn't run interop tests
- `mvn verify` - runs interop tests, fails if submodule files are not there
- `mvn verify -P ci-test` - update git submodules and then run interop test,
fail if not inside git repo, e.g. if it's a tarball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
> Key: PARQUET-1992
> URL: https://issues.apache.org/jira/browse/PARQUET-1992
> Project: Parquet
> Issue Type: Bug
> Reporter: Gabor Szadovszky
> Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and
> somehow avoid the git submodule update in case of executed in a non-git
> envrionment
> * Make the downloading of the parquet files and the related tests optional so
> it won't fail the build from the tarball
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
