[ 
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296124#comment-17296124
 ] 

Xinli Shang commented on PARQUET-1992:
--------------------------------------

I think we shouldn't let it fail when developers run 'mvn package/install' or 
'mvn verify' in any case if they don't make any changes.  So I like the idea of 
downloading directly.  I will review the code once it passes the build. 

> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
>                 Key: PARQUET-1992
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1992
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Gabor Szadovszky
>            Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean 
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and 
> somehow avoid the git submodule update in case of executed in a non-git 
> envrionment
> * Make the downloading of the parquet files and the related tests optional so 
> it won't fail the build from the tarball



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to