[
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297608#comment-17297608
]
ASF GitHub Bot commented on PARQUET-1992:
-----------------------------------------
gszadovszky commented on a change in pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878#discussion_r589627173
##########
File path:
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
##########
@@ -299,13 +309,15 @@ public void testWriteReadEncryptedParquetFiles() throws
IOException {
testReadEncryptedParquetFiles(rootPath, DATA);
}
- @Test
- public void testInteropReadEncryptedParquetFiles() throws IOException {
+ public void testInteropReadEncryptedParquetFiles(ErrorCollector
errorCollector, OkHttpClient httpClient) throws IOException {
Review comment:
Please add some notes that this method is deliberately not annotated by
`@Test` and used elsewhere.
##########
File path:
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/ITTestEncryptionOptions.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.hadoop;
+
+import org.junit.Test;
+import org.junit.Rule;
+import org.junit.rules.ErrorCollector;
+
+import okhttp3.OkHttpClient;
+
+
+import java.io.IOException;
+
+/*
+ * This file continues the testing in TestEncryptionOptions. This test goals:
+ * 4) Perform interoperability tests with other (eg parquet-cpp) writers, by
reading
Review comment:
The number `4` does not make too much sense here.
##########
File path: .gitignore
##########
@@ -19,3 +19,4 @@ target/
.cache
*~
mvn_install.log
+parquet-hadoop/parquet-testing
Review comment:
I would suggest using either a temporary directory outside of source
tree or a place the files inside the `target` directory. `target` would have
the benefit that it is not cleaned until explicitly invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
> Key: PARQUET-1992
> URL: https://issues.apache.org/jira/browse/PARQUET-1992
> Project: Parquet
> Issue Type: Bug
> Reporter: Gabor Szadovszky
> Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and
> somehow avoid the git submodule update in case of executed in a non-git
> envrionment
> * Make the downloading of the parquet files and the related tests optional so
> it won't fail the build from the tarball
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
