Randy Kobes wrote:
On Thu, 8 Jul 2004, Steve Hay wrote:
[ ... ]

I now have all tests successful in the main test suite and
ModPerl-Registry's.

Hi Steve, That's great! Does this mean also that the protocol/echo_bbs2 test passes for you? A few days ago it was crashing on me, but I haven't tested that particular test yet with the current cvs.

Nothing has changed so far.

Any improvements with this change?


Index: t/protocol/TestProtocol/echo_bbs2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
retrieving revision 1.5
diff -u -r1.5 echo_bbs2.pm
--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 -0000 1.5
+++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000
@@ -34,7 +34,6 @@
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;


         next unless $bb_in->flatten(my $data);
-        $bb->cleanup;
         #warn "read: [$data]\n";
         last if $data =~ /^[\r\n]+$/;

@@ -43,6 +42,7 @@
         $bb->insert_tail($bucket);

         $c->output_filters->fflush($bb);
+        $bb->cleanup;
     }

     $bb->destroy;


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to