On Thu, 8 Jul 2004, Stas Bekman wrote: > Randy Kobes wrote: [ ... ] > > That's great! Does this mean also that the > > protocol/echo_bbs2 test passes for you? A few days > > ago it was crashing on me, but I haven't tested that > > particular test yet with the current cvs. > > Nothing has changed so far. > > Any improvements with this change? > > > Index: t/protocol/TestProtocol/echo_bbs2.pm > =================================================================== > RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v > retrieving revision 1.5 > diff -u -r1.5 echo_bbs2.pm > --- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 > -0000 1.5 > +++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000 > @@ -34,7 +34,6 @@ > die APR::Error::strerror($rc) unless $rc == APR::SUCCESS; > > next unless $bb_in->flatten(my $data); > - $bb->cleanup; > #warn "read: [$data]\n"; > last if $data =~ /^[\r\n]+$/; > > @@ -43,6 +42,7 @@ > $bb->insert_tail($bucket); > > $c->output_filters->fflush($bb); > + $bb->cleanup; > } > > $bb->destroy;
Unfortunately (or fortunately :), for me with perl-5.8.0 and Apache/2.0.50, this test now passes, without the above change, with the current cvs. So maybe some recent changes fixed this? I do have a problem with one of the recent modperl/pnotes tests that were added, but I'll look into that some more in a separate message. -- best regards, randy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
