On Mon, 12 Jul 2004, Stas Bekman wrote:

> > No, no change - I still get it crashing (perl-5.8.4,
> > Apache/2.0.50, Win32).
>
> Thanks for testing, Randy and Steve. How about this patch:
>
> Index: t/protocol/TestProtocol/echo_bbs2.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
> retrieving revision 1.5
> diff -u -r1.5 echo_bbs2.pm
> --- t/protocol/TestProtocol/echo_bbs2.pm      1 Jul 2004 02:01:21 -0000       1.5
> +++ t/protocol/TestProtocol/echo_bbs2.pm      12 Jul 2004 08:12:14 -0000
> @@ -27,16 +27,14 @@
>
>       my $last = 0;
>       while (1) {
> -        my $bb_in  = APR::Brigade->new($c->pool, $c->bucket_alloc);
> -        my $rc = $c->input_filters->get_brigade($bb_in,
> +        my $rc = $c->input_filters->get_brigade($bb,
>                                                   Apache::MODE_GETLINE);
>           last if $rc == APR::EOF;
>           die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>
> -        next unless $bb_in->flatten(my $data);
> -        $bb->cleanup;
> -        #warn "read: [$data]\n";
> +        next unless $bb->flatten(my $data);
>           last if $data =~ /^[\r\n]+$/;
> +        $bb->cleanup;
>
>           # transform data here
>           my $bucket = APR::Bucket->new(uc $data);
> @@ -45,6 +43,7 @@
>           $c->output_filters->fflush($bb);
>       }
>
> +    # XXX: add DESTROY and remove explicit calls
>       $bb->destroy;
>
>       Apache::OK;

I still have it crashing ... This is with Apache/2.0.50 -
Steve, is your Perl similar to mine?

Summary of my perl5 (revision 5 version 8 subversion 4) configuration:
  Platform:
    osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    usethreads=undef use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cl', ccflags ='-nologo -Gf -W3 -MD -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT 
-DHAVE_DES_FCRYPT  -DNO_HASH_SEED -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS 
-DUSE_PERLIO -DPERL_MSVCRT_READFIX',
    optimize='-MD -DNDEBUG -O1',
    cppflags='-DWIN32'
    ccversion='', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -release  -libpath:"D:\Perl\lib\CORE"  
-machine:x86'
    libpth=\lib
    libs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib wsock32.lib 
mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    perllibs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib 
wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=yes, libperl=perl58.lib
    gnulibc_version='undef'
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release  
-libpath:"D:\Perl\lib\CORE"  -machine:x86'


Characteristics of this binary (from libperl):
  Compile-time options: MULTIPLICITY USE_ITHREADS USE_LARGE_FILES 
PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS
  Locally applied patches:
        ActivePerl Build 810
        22751 Update to Test.pm 1.25
        21540 Fix backward-compatibility issues in if.pm
  Built under MSWin32
  Compiled at Jun 17 2004 21:47:33
  @INC:
    D:/Perl/lib
    D:/Perl/site/lib
    .


-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to