No, no change - I still get it crashing (perl-5.8.4,
Apache/2.0.50, Win32).
Thanks for testing, Randy and Steve. How about this patch:
Index: t/protocol/TestProtocol/echo_bbs2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
retrieving revision 1.5
diff -u -r1.5 echo_bbs2.pm
--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 -0000 1.5
+++ t/protocol/TestProtocol/echo_bbs2.pm 12 Jul 2004 08:12:14 -0000
@@ -27,16 +27,14 @@
my $last = 0;
while (1) {
- my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
- my $rc = $c->input_filters->get_brigade($bb_in,
+ my $rc = $c->input_filters->get_brigade($bb,
Apache::MODE_GETLINE);
last if $rc == APR::EOF;
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
- next unless $bb_in->flatten(my $data);
- $bb->cleanup;
- #warn "read: [$data]\n";
+ next unless $bb->flatten(my $data);
last if $data =~ /^[\r\n]+$/;
+ $bb->cleanup;
# transform data here
my $bucket = APR::Bucket->new(uc $data);
@@ -45,6 +43,7 @@
$c->output_filters->fflush($bb);
}
+ # XXX: add DESTROY and remove explicit calls
$bb->destroy;
Apache::OK;
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
