[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134740#comment-14134740
]
ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------
GitHub user elilevine opened a pull request:
https://github.com/apache/phoenix/pull/15
Logging custom annotations for PHOENIX-1198
This PR adds custom annotations to log lines generated in Phoenix's
client-side code. It builds on PR https://github.com/apache/phoenix/pull/13 and
uses the same mechanism to pass custom annotations to connections. These custom
annotations are only added to client-side code logging that is within the
context of a user operation (meaning a PhoenixConnection is available). No new
log lines are added here. Only existing log lines are changed.
Usage:
1. Add custom annotation properties when creating a Phoenix Connection.
e.g. `phoenix.trace.custom.annotation.a1=v1`
2. Log lines in (some of) Phoenix's client-side code would look like this:
`{a1=v1} something logged`
Ignore the following files here, since they are covered in PR #13:
BaseTracingTestIT.java, PhoenixTracingEndToEndIT.java, TraceReader.java,
Tracing.java, JDBCUtilTest.java
@jtaylor-sfdc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elilevine/apache-phoenix
logging-custom-annotations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 786c6e6318c0945f818f1498545efeba43fb4b05
Author: Eli Levine <[email protected]>
Date: 2014-09-11T19:17:54Z
First pass at custom tracing annotations
commit 07247764ed93f293fd8e99ba4ba36e32cdf99068
Author: Eli Levine <[email protected]>
Date: 2014-09-11T19:28:03Z
Merge upstream changes
commit 7a0f552589653a5d9e2f60a287e867e450e3861e
Author: Eli Levine <[email protected]>
Date: 2014-09-15T23:06:20Z
Custom annotations in logs for client-side code that works within the
context of a user operation (PhoenixConnection is available)
----
> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
