[
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134767#comment-14134767
]
Eli Levine commented on PHOENIX-1198:
-------------------------------------
I made a first pass at adding annotations for logging done in client-side code:
https://github.com/apache/phoenix/pull/15
With respect to adding annotations to server-side logging, I think we only need
to do that for code that services client operations. That would allow us to
take custom annotations from PheonixConnection and pass them to the server. I
see these options for passing custom annotation to the server:
1. Change method signatures of Phoenix coprocesor methods to accept custom
annotations. Main downside with this approach is the many interface changes,
which might make upgrades difficult.
2. Another approach is to add annotations to Mutations and Scans that are
passed into Phoenix coprocessor methods using
OperationWithAttributes.setAttribute() method. Should be fine for Scans but is
probably overkill to add to every Mutation if a coprocessor method accepts
Mutation batches. Maybe just add to the first Mutation in a batch?
> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
> Key: PHOENIX-1198
> URL: https://issues.apache.org/jira/browse/PHOENIX-1198
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same
> mechanism for passing in values to be logged/traced.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
