[ 
https://issues.apache.org/jira/browse/PHOENIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235090#comment-14235090
 ] 

James Taylor commented on PHOENIX-1453:
---------------------------------------

[~ramkrishna] - keep it the way you have it in your last patch: separate 
columns for GUIDE_POSTS and GUIDE_POSTS_ROW_COUNT. If you could make the 
changes I mentioned here: 
https://issues.apache.org/jira/browse/PHOENIX-1453?focusedCommentId=14229339&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14229339

and change StatisticsCollector.updateStatistic(KeyValue kv) to  
StatisticsCollector.updateStatistic(List<Cell> cells) so that you no longer 
need to compare the row key each time, I think that'll be all.

> Collect row counts per region in stats table
> --------------------------------------------
>
>                 Key: PHOENIX-1453
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1453
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: Phoenix-1453.patch, Phoenix-1453_1.patch, 
> Phoenix-1453_2.patch, Phoenix-1453_3.patch
>
>
> We currently collect guideposts per equal chunk, but we should also capture 
> row counts. Should we have a parallel array with the guideposts that count 
> rows per guidepost, or is it enough to have a per region count?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to