[
https://issues.apache.org/jira/browse/PHOENIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237588#comment-14237588
]
James Taylor commented on PHOENIX-1453:
---------------------------------------
Thanks for the patch, [~ramkrishna]. The logic for incrementing the row count
doesn't look quite right. I think there are two cases:
- if cachedGps != null, then I think your logic is correct, but I think it'd be
easier to just do this +1 outside the look in this case rather than have a
boolean incrRowCount variable
- if cachedGps == null, then you need to increment each column family you
encounter in the loop once.
I think the simplest way is to just keep a list of the GuidePostsInfo you
encounter inside the loop. Then afterwards, outside the loop, just increment
the row count of each GuidePostsInfo in the list by one.
> Collect row counts per region in stats table
> --------------------------------------------
>
> Key: PHOENIX-1453
> URL: https://issues.apache.org/jira/browse/PHOENIX-1453
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1453.patch, Phoenix-1453_1.patch,
> Phoenix-1453_2.patch, Phoenix-1453_3.patch, Phoenix-1453_7.patch
>
>
> We currently collect guideposts per equal chunk, but we should also capture
> row counts. Should we have a parallel array with the guideposts that count
> rows per guidepost, or is it enough to have a per region count?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
