[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247365#comment-14247365
]
Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------
bq. So, just to confirm, your patch is back to only making the minimum required
structural changes, right? The items you mentioned before[1] are not part of
this patch?
The only piece that's still in place from [1] is the 2nd point:
- PhoenixArray#elements is left as the type provided by the constructor.
Primitive implementations no longer overwrite this instance with the primitive
version (they maintain the primitive version as a separate variable for
optimized uses)
bq. To prevent the test from hanging, can you try with reuseForks=false? Do you
get any hanging test in your local env without your changes and if so which
ones? What does your local env look like?
As mentioned in PHOENIX-1528, reuseForks=false seemed to help. When I run
verify vs master/HEAD, I get lots of verification failures. I'm running on a
Mac 10.9.5, java version "1.7.0_67".
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
