[ 
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247388#comment-14247388
 ] 

James Taylor commented on PHOENIX-1514:
---------------------------------------

Do you get verification failures without your changes too? I assume you're 
using HBase 0.98.4 as that's what the pom is set back to using? I use a Mac at 
home too, but don't have any hanging tests - I'll send out my env when I get 
home.

As far as PhoenixArray, we wouldn't want to hold on to the Integer[] 
representation, but instead only the int[] representation, for example, as for 
big arrays this could be significant. That's why the array was declared as an 
Object. Maybe we can get rid of the declaration completely in the PhoenixArray 
type, make it abstract, and only hold on to it in the concrete subclasses?

> Break up PDataType Enum
> -----------------------
>
>                 Key: PHOENIX-1514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1514
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch, 
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up 
> the PDataType enum into an interface. This will pave the way for more 
> flexibility going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to