ottobackwards commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r441131919
##########
File path: sandbox/plc4c/generated-sources/modbus/src/modbus_constants.c
##########
@@ -24,18 +24,18 @@
#include "modbus_constants.h"
// Parse function.
-plc4c_return_code
plc4c_modbus_read_write_modbus_constants_parse(plc4c_spi_read_buffer* buf,
plc4c_modbus_read_write_modbus_constants** message) {
+plc4c_return_code
plc4c_modbus_read_write_modbus_constants_parse(plc4c_spi_read_buffer* buf,
plc4c_modbus_read_write_modbus_constants** _message) {
Review comment:
to me, when I see _var_name I think of a private var, not only in python
but in some c-ish languages I've worked in. is there some standard that you
are writing two using _ in a parameter name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
