ottobackwards commented on pull request #168: URL: https://github.com/apache/plc4x/pull/168#issuecomment-645005753
that is too much to look through all of it. It looks good. A couple of things that come to mind: - can we run clang-format after generation? - should we be generating some logging? - _message as a parameter is strange to _me_ - so many (*_message)-> everywhere, can we use a typedef or something? None of these things are for this PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
