chrisdutz commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r442009007
##########
File path: sandbox/plc4c/generated-sources/modbus/src/modbus_constants.c
##########
@@ -24,18 +24,18 @@
#include "modbus_constants.h"
// Parse function.
-plc4c_return_code
plc4c_modbus_read_write_modbus_constants_parse(plc4c_spi_read_buffer* buf,
plc4c_modbus_read_write_modbus_constants** message) {
+plc4c_return_code
plc4c_modbus_read_write_modbus_constants_parse(plc4c_spi_read_buffer* buf,
plc4c_modbus_read_write_modbus_constants** _message) {
Review comment:
Well I had to somehow make sure the names a user can choose in mspec
don't interfere with those used internally ... so I prefixed them with a "_" if
you have another suggestion, I'm fine with changing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
