chrisdutz commented on pull request #168: URL: https://github.com/apache/plc4x/pull/168#issuecomment-645823603
> that is too much to look through all of it. > It looks good. A couple of things that come to mind: > > * can we run clang-format after generation? > * should we be generating some logging? > * _message as a parameter is strange to _me_ > * so many (*_message)-> everywhere, can we use a typedef or something? > > None of these things are for this PR Well I would rather have the code generated in a way that it doesn't require formatting ... I didn't generate any logging as I didn't know of any logging framework to use ... we could whip up a skeleton of functions that we can use for logging and plug in a "printf" logger or whatever we like to do the actual logging ... that might be a good idea. As I mentioned before ... I wanted to ensure the internal variable names don't clash with the ones a user can use in mspec ... people tent to get anoyed if they have to use other named due to internal stuff. Why do we need to typedef that ... It's not that anyone is ever going to write that code ... but if you like, of course that's probably a really simple change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
