gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r727973563
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -78,12 +79,15 @@ class test_recv : public proton::messaging_handler {
}
void on_message(proton::delivery &d, proton::message &msg) override {
- proton::binary test_tag_recv("TESTTAG");
- ASSERT_EQUAL(test_tag_recv, d.tag());
+ ASSERT_EQUAL(test_tag, d.tag());
d.receiver().close();
d.connection().close();
listener.stop();
}
+
+ void on_delivery_settle(proton::delivery &d) override {
+ ASSERT_EQUAL(test_tag, d.tag());
+ }
Review comment:
I would guess its because the receiver is settling first, not the sender
(the server), so it doesnt make sense for this to ever fire in that case as the
delivery has been forgotten about at that point. (I expect it would typically
only be used in 'receiver settles second' settlement mode, which nothing really
uses).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
