gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r738284530
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,8 +102,16 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_settle(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
Review comment:
I created a second different tag and modified each assertion in turn to
compare against it rather than the one set set on the send.
It cause the test to fail when the first assertion (right after the send
call) was changed, but the test still passed when the other two were modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
