gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r738295917
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,8 +102,16 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_settle(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
Review comment:
Belay this. I have no idea how I've managed it, but I just noticed that
during my changes my other_tag content somehow got reverted to the same
"TESTTAG" content as the original test_tag, so although I was comparing
different tags values on the 2nd and 3rd assertion changes..they were equal.
Siiiiiigh :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
