gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r738519994
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,14 +104,27 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ s.connection().close();
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ tracker_accept_counter++;
+ ASSERT_EQUAL(test_tag, t.tag());
Review comment:
The increment should probably go after the assertion, just to be sure it
has to succeed to bump the counter. Shouldnt make a difference, but you never
know.
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,14 +104,27 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ s.connection().close();
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ tracker_accept_counter++;
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_settle(proton::tracker &t) override {
+ tracker_settle_counter++;
+ ASSERT_EQUAL(test_tag, t.tag());
}
};
int test_delivery_tag() {
+ tracker_accept_counter = 0;
+ tracker_settle_counter = 0;
+
Review comment:
There looks to be some whitespace on this line that can probably go.
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,14 +104,27 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ s.connection().close();
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ tracker_accept_counter++;
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_settle(proton::tracker &t) override {
+ tracker_settle_counter++;
+ ASSERT_EQUAL(test_tag, t.tag());
Review comment:
The increment should probably go after the assertion, just to be sure it
has to succeed to bump the count. Shouldnt make a difference, but you never
know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
