jiridanek commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558367543
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
Flake 8 looks inside # type: comments and complains if it is using
something that wasn't declared; I'd leave the comment, type annotations are
awesome and when Python 2.7 is dropped, they can be used more fully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
